Re: [PATCH v2 2/2] iio: accel: fxls8962af: Fix sign temperature scan element

[Jonathan Cameron]

On Sat, 3 May 2025 10:57:09 -0300
Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote:

> On 05/02, Sean Nyekjaer wrote:
> > TEMP_OUT register contains the 8-bit, 2's complement temperature value.
> > Let's mark the temperature scan element signed.
> > 
> > Fixes: a3e0b51884ee ("iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers")
> > Suggested-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>  
> 
> Sort of nitpinking but I think the commit description could be more assertive.

Agreed.  I might have just tweaked it to
"Mark the temperature element signed."  + some of what Marcelo has below.
but given Andy's request on patch 1 means you are probably doing a v3, please
tidy this up as well.

Thanks and good catches on both of them!

Jonathan

> The main idea is that we want to make the scan element signed because the
> data read from the TEMP_OUT register is in two's complement format and not
> having the scan element marked as a signed number may cause it to be mishandled
> and miss displayed. Nevertheless, I do think the patch is good so
> 
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>
>