Re: [RFC PATCH 2/5] iio: adc: Kconfig: add Kconfig entry for TI ADS1262 driver
From: Jonathan Cameron
Date: Sun May 04 2025 - 11:55:42 EST
On Thu, 1 May 2025 12:37:35 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> On 5/1/25 5:00 AM, Sayyad Abid wrote:
> > Adds the Kconfig option `CONFIG_TI_ADS1262` under the IIO ADC menu.
> > This allows users to select the TI ADS1262 driver for compilation
> > during kernel configuration.
> >
> > Signed-off-by: Sayyad Abid <sayyad.abid16@xxxxxxxxx>
> > ---
> This can be in the same patch as the driver. Same with the makefile - it doesn't
> need to be a separate patch.
Change that from can to should / must. There are some bits of the kernel
that run a different approach for complex multi patch drivers but for
IIO we want everything to be building at each step of the series.
Personally I see that as good practice and I don't know of any part of the
kernel where the maintainers reject that approach, just some where they
don't mind as much if a complex driver is built up and only compiled in
the final patch
Thanks,
Jonathan