Re: [PATCH v5 7/8] man/man2/open_tree{,_attr}.2: document new open_tree_attr() API
From: Askar Safin
Date: Tue Sep 30 2025 - 20:38:51 EST
Aleksa Sarai <cyphar@xxxxxxxxxx>:
> +mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> + &attr, sizeof(attr));
Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
calls. :)
I think you meant open_tree_attr here.
> +\&
> +/* Create a new copy with the id-mapping cleared */
> +memset(&attr, 0, sizeof(attr));
> +attr.attr_clr = MOUNT_ATTR_IDMAP;
> +mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> + &attr, sizeof(attr));
And here.
Otherwise your whole patchset looks good. Add to whole patchset:
Reviewed-by: Askar Safin <safinaskar@xxxxxxxxx>
--
Askar Safin