Re: [PATCH v2] mtd: rawnand: cadence: Add support for NV-DDR interface mode

[Miquel Raynal]

Hi,

> +	if (nand_interface_is_sdr(conf)) {
> +		const struct nand_sdr_timings *sdr = nand_get_sdr_timings(conf);
> +
> +		if (IS_ERR(sdr))
> +			return PTR_ERR(sdr);
> +
> +		ret = cadence_nand_setup_sdr_interface(chip, sdr);
> +	} else {
> +		if (chipnr < 0)
> +			return ret;

I still think this is incorrect. The chipnr value shall not be treated
differently from the SDR path.

Thanks,
Miquèl