Re: [PATCH v6 3/3] samples: rust: add Rust I2C sample driver
From: Danilo Krummrich
Date: Sun Oct 26 2025 - 11:43:54 EST
On 10/26/25 3:06 PM, Igor Korotin wrote:
> Hello Danilo
>
> On 10/26/2025 10:48 AM, Danilo Krummrich wrote:
>> On 10/5/25 12:23 PM, Igor Korotin wrote:
>>> +impl Drop for SampleDriver {
>>> + fn drop(&mut self) {
>>> + dev_info!(self.idev.as_ref(), "Remove Rust I2C driver sample.\n");
>>> + }
>>> +}
>>
>> NIT: Please use the i2c::Driver::unbind() callback instead.
>
> Thanks for the feedback.
> I’ll move this into the i2c::Driver::unbind() callback.
>
> Should I send v7?
For such a minor thing I can usually do it when applying the patch, but given
that for the other patch the change is a bit more significant, I'd say please
send a v7.