Re: [PATCH v6 3/3] samples: rust: add Rust I2C sample driver

From: Igor Korotin
Date: Sun Oct 26 2025 - 11:50:19 EST


On 10/26/2025 3:43 PM, Danilo Krummrich wrote:
On 10/26/25 3:06 PM, Igor Korotin wrote:
Hello Danilo

On 10/26/2025 10:48 AM, Danilo Krummrich wrote:
On 10/5/25 12:23 PM, Igor Korotin wrote:
+impl Drop for SampleDriver {
+    fn drop(&mut self) {
+        dev_info!(self.idev.as_ref(), "Remove Rust I2C driver sample.\n");
+    }
+}

NIT: Please use the i2c::Driver::unbind() callback instead.

Thanks for the feedback.
I’ll move this into the i2c::Driver::unbind() callback.

Should I send v7?

For such a minor thing I can usually do it when applying the patch, but given
that for the other patch the change is a bit more significant, I'd say please
send a v7.

Just for the clarification: by "the change for the other patch" you mean rebase and update this patch series based on [1], right?

Thanks
Igor

[1] https://lore.kernel.org/all/20251016125544.15559-1-dakr@xxxxxxxxxx/