Re: [PATCH v3] drm/sched: Add warning for removing hack in drm_sched_fini()

From: Philipp Stanner

Date: Fri Oct 31 2025 - 10:48:00 EST


On Fri, 2025-10-31 at 15:10 +0100, Pierre-Eric Pelloux-Prayer wrote:
> Hi Philipp,
>
> Le 23/10/2025 à 14:34, Philipp Stanner a écrit :
> > The assembled developers agreed at the X.Org Developers Conference 2025
> > that the hack added for amdgpu in drm_sched_fini() shall be removed. It
> > shouldn't be needed by amdgpu anymore.
> >
> > As it's unclear whether all drivers really follow the life time rule of
> > entities having to be torn down before their scheduler, it is reasonable
> > to warn for a while before removing the hack.
> >
> > Add a warning in drm_sched_fini() that fires if an entity is still
> > active.
> >
> > Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>

[…]

>
> The patch is Acked-by: Pierre-Eric Pelloux-Prayer
> <pierre-eric.pelloux-prayer@xxxxxxx>

Pushed to drm-misc-next, thanks.

For the future: b4 / maintainer-tools wasn't able to automatically
harvest your Acked-by. Would be helpful if you have the A-b on a single
line without line break and without other content in the future

Have a nice weekend,
P.

>
> Thanks.
>
>
> >    spin_unlock(&rq->lock);
> >    kfree(sched->sched_rq[i]);
> >    }