Re: [PATCH] cxl/pci: replace use of system_wq with system_percpu_wq

From: Ira Weiny

Date: Fri Oct 31 2025 - 10:46:59 EST


Marco Crivellari wrote:
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
>
> This lack of consistency cannot be addressed without refactoring the API.
>
> system_wq should be the per-cpu workqueue, yet in this name nothing makes
> that clear, so replace system_wq with system_percpu_wq.
>
> The old wq (system_wq) will be kept for a few release cycles.

A reference to:

commit 128ea9f6ccfb6960293ae4212f4f97165e42222d
Author: Marco Crivellari <marco.crivellari@xxxxxxxx>
Date: Sat Jun 14 15:35:29 2025 +0200

workqueue: Add system_percpu_wq and system_dfl_wq

...

Would have been nice just to save reviewers time. Regardless.

Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>

[snip]