Re: [PATCH 0/7] arm64: dts: qcom: cleanup GPU's zap-shader node

[Konrad Dybcio]

On 10/29/25 1:35 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 29, 2025 at 10:36:45AM +0100, Konrad Dybcio wrote:
>> On 10/29/25 10:35 AM, Dmitry Baryshkov wrote:
>>> On 29/10/2025 11:33, Konrad Dybcio wrote:
>>>> On 10/28/25 9:59 PM, Dmitry Baryshkov wrote:
>>>>> Historically all devices manually defined GPU zap-shader node in their
>>>>> board DT files. This practice is frowned upon. Add the zap-shader node
>>>>> on all platforms, define a label for it and use the label in order to
>>>>> patch the node with the firmware name.
>>>>
>>>> I'm not sure this is much of an improvement, since at the end of the
>>>> series, boards still have a &gpu { zap-shader {} } section, with the
>>>> inner one not being referred to through a label, which reduces
>>>> duplication in the single LoC used to assign memory-region, but
>>>> doesn't e.g. prevent typos in the zap-shader node name
>>>
>>> By the end of the series the boards don't have zap-shader{}. They use &gpu_zap_shader { firmware-name = "something" ; };
>>
>> /me wipes glasses
>>
>> You're right, I skipped over the last patch
> 
> R-B ?

rb!

Konrad