Re: [PATCH v4 5/7] PCI: spacemit: introduce SpacemiT PCIe host driver
From: Alex Elder
Date: Thu Oct 30 2025 - 21:16:21 EST
On 10/30/25 6:08 PM, Bjorn Helgaas wrote:
In subject, capitalize "introduce" to match history. Or you could
just use "Add ...", which has the advantage of being shorter.
OK. I'll capitalize all of them in this series.
On Thu, Oct 30, 2025 at 05:02:56PM -0500, Alex Elder wrote:
Introduce a driver for the PCIe host controller found in the SpacemiT
K1 SoC. The hardware is derived from the Synopsys DesignWare PCIe IP.
The driver supports three PCIe ports that operate at PCIe gen2 transfer
rates (5 GT/sec). The first port uses a combo PHY, which may be
configured for use for USB 3 instead.
...
I guess this doesn't support INTx interrupts at all?
It can, but I removed that support first to simplify the task
of converting the original code, and second because I had no way
to test it. I planned for it to be added at a future date.
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -509,6 +509,17 @@ config PCI_KEYSTONE_EP
on DesignWare hardware and therefore the driver re-uses the
DesignWare core functions to implement the driver.
+config PCIE_SPACEMIT_K1
+ tristate "SpacemiT K1 PCIe controller (host mode)"
Move this to keep the menu items alphabetized by vendor.
OK. I was going by Kconfig option name, but now I see
what you mean.
I'll put it between PCIE_SOPHGO_DW and PCIE_SPEAR13XX.
+ depends on ARCH_SPACEMIT || COMPILE_TEST
+ depends on PCI && OF && HAS_IOMEM
I don't think you need PCI or OF.
You're right. PCI for sure, but it doesn't look like I make
an direct OF calls either. I'll drop them both.
I guess I didn't include "SpacemiT". I'll add that, and will try+ select PCIE_DW_HOST
+ select PCI_PWRCTRL_SLOT
+ default ARCH_SPACEMIT
+ help
+ Enables support for the PCIe controller in the K1 SoC operating
+ in host mode.
Most help text includes both the vendor and the product line names.
to come up with a few more words in the description.
Thanks for your quick response.
-Alex