Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible

[Bjorn Andersson]

On Sun, Nov 02, 2025 at 11:25:06PM -0800, Jingyi Wang wrote:
> Document qcom,kaanapali-imem compatible. Kaanapali IMEM is not a syscon or
> simple-mfd, also "reboot reason" is not required on Kaanapali like some
> other platforms. So define a common "qcom,imem" binding and fallback to it.
> Currently there is no requirement for any specific implementation for the
> "qcom,imem". Its child node "qcom,pil-reloc-info" has no implementation
> dependency on IMEM.

I think this could have captured the discussion leading up to this
result a bit better, and the fact that this isn't unique to Kaanapali.

But I won't insist on a rewrite.

> 
> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>

Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>

Regards,
Bjorn

> ---
>  .../devicetree/bindings/sram/qcom,imem.yaml        | 77 ++++++++++++----------
>  1 file changed, 41 insertions(+), 36 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> index 6a627c57ae2f..09278b21acf4 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> @@ -15,42 +15,47 @@ description:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - qcom,apq8064-imem
> -          - qcom,ipq5424-imem
> -          - qcom,msm8226-imem
> -          - qcom,msm8974-imem
> -          - qcom,msm8976-imem
> -          - qcom,qcs404-imem
> -          - qcom,qcs615-imem
> -          - qcom,qcs8300-imem
> -          - qcom,qdu1000-imem
> -          - qcom,sa8775p-imem
> -          - qcom,sar2130p-imem
> -          - qcom,sc7180-imem
> -          - qcom,sc7280-imem
> -          - qcom,sc8280xp-imem
> -          - qcom,sdm630-imem
> -          - qcom,sdm845-imem
> -          - qcom,sdx55-imem
> -          - qcom,sdx65-imem
> -          - qcom,sdx75-imem
> -          - qcom,sm6115-imem
> -          - qcom,sm6125-imem
> -          - qcom,sm6350-imem
> -          - qcom,sm6375-imem
> -          - qcom,sm7150-imem
> -          - qcom,sm8150-imem
> -          - qcom,sm8250-imem
> -          - qcom,sm8350-imem
> -          - qcom,sm8450-imem
> -          - qcom,sm8550-imem
> -          - qcom,sm8650-imem
> -          - qcom,sm8750-imem
> -          - qcom,x1e80100-imem
> -      - const: syscon
> -      - const: simple-mfd
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,apq8064-imem
> +              - qcom,ipq5424-imem
> +              - qcom,msm8226-imem
> +              - qcom,msm8974-imem
> +              - qcom,msm8976-imem
> +              - qcom,qcs404-imem
> +              - qcom,qcs615-imem
> +              - qcom,qcs8300-imem
> +              - qcom,qdu1000-imem
> +              - qcom,sa8775p-imem
> +              - qcom,sar2130p-imem
> +              - qcom,sc7180-imem
> +              - qcom,sc7280-imem
> +              - qcom,sc8280xp-imem
> +              - qcom,sdm630-imem
> +              - qcom,sdm845-imem
> +              - qcom,sdx55-imem
> +              - qcom,sdx65-imem
> +              - qcom,sdx75-imem
> +              - qcom,sm6115-imem
> +              - qcom,sm6125-imem
> +              - qcom,sm6350-imem
> +              - qcom,sm6375-imem
> +              - qcom,sm7150-imem
> +              - qcom,sm8150-imem
> +              - qcom,sm8250-imem
> +              - qcom,sm8350-imem
> +              - qcom,sm8450-imem
> +              - qcom,sm8550-imem
> +              - qcom,sm8650-imem
> +              - qcom,sm8750-imem
> +              - qcom,x1e80100-imem
> +          - const: syscon
> +          - const: simple-mfd
> +      - items:
> +          - enum:
> +              - qcom,kaanapali-imem
> +          - const: qcom,imem
>  
>    reg:
>      maxItems: 1
> 
> -- 
> 2.25.1
>