Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible

[Krzysztof Kozlowski]

On Sun, Nov 02, 2025 at 11:25:06PM -0800, Jingyi Wang wrote:
> Document qcom,kaanapali-imem compatible. Kaanapali IMEM is not a syscon or
> simple-mfd, also "reboot reason" is not required on Kaanapali like some

I do not see correlation. Something is not a syscon, so you add a new
generic compatible? No.

> other platforms. So define a common "qcom,imem" binding and fallback to it.

You did not define fallback to it!

...

> +      - items:
> +          - enum:
> +              - qcom,kaanapali-imem
> +          - const: qcom,imem

I do not understand what this generic compatible is supposed to express,
not explained in commit msg. Considering this wasn't before, it is a
major and really undesired change. It also makes no sesne. There was no
generic compatible before but "if not syscon" now this must have generic
compatible, what?

NAK

Best regards,
Krzysztof