Re: [PATCH v3 4/5] dt-bindings: clock: airoha: Document support for AN7583 clock
From: Christian Marangi
Date: Fri Nov 07 2025 - 02:45:23 EST
On Fri, Nov 07, 2025 at 08:42:15AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 06, 2025 at 08:59:31PM +0100, Christian Marangi wrote:
> > Document support for Airoha AN7583 clock based on the EN7523
> > clock schema.
> >
> > Add additional binding for additional clock and reset lines.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > ---
> > .../bindings/clock/airoha,en7523-scu.yaml | 5 +-
> > include/dt-bindings/clock/en7523-clk.h | 3 +
> > .../dt-bindings/reset/airoha,an7583-reset.h | 62 +++++++++++++++++++
> > 3 files changed, 69 insertions(+), 1 deletion(-)
> > create mode 100644 include/dt-bindings/reset/airoha,an7583-reset.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > index fe2c5c1baf43..2d53b96356c5 100644
> > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> > @@ -30,6 +30,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - airoha,an7583-scu
>
> That's random order. Keep it sorted.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
I was also not cetrain on the correct order.
We have En7523 and en7581 and then An7583.
So should I put it at last following the number order or the
alphabetical order?
--
Ansuel