Re: [PATCH v7 2/2] clock: eswin: Add eic7700 clock driver

[Troy Mitchell]

On Thu, Oct 23, 2025 at 03:18:14PM +0800, dongxuyang@xxxxxxxxxxxxxxxxxx wrote:
> From: Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> 
> Add clock drivers for the EIC7700 SoC. The clock controller on the ESWIN
> EIC7700 provides various clocks to different IP blocks within the SoC.
> 
> Signed-off-by: Yifeng Huang <huangyifeng@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> ---
[...]
> diff --git a/drivers/clk/eswin/Kconfig b/drivers/clk/eswin/Kconfig
> new file mode 100644
> index 000000000000..9bc9008d3156
> --- /dev/null
> +++ b/drivers/clk/eswin/Kconfig
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +config COMMON_CLK_ESWIN
> +	bool
> +
> +config COMMON_CLK_EIC7700
> +	bool "EIC7700 Clock Driver"
We can't build this driver as module?
If no, see here: https://lore.kernel.org/all/Z%2FlN7qrISpbK6MQY@xxxxxxxxxxxxxxxxxxxxxxxx/

> +	depends on ARCH_ESWIN || COMPILE_TEST
> +	select COMMON_CLK_ESWIN
> +	default ARCH_ESWIN
> +	help
> +	  This driver provides support for clock controller on ESWIN EIC7700
> +	  SoC. The clock controller can generates and supplies clock to various
> +	  peripherals within the SoC.
> +	  Say yes here to support the clock controller on the EIC7700 SoC.
[...]
> diff --git a/drivers/clk/eswin/clk-eic7700.c b/drivers/clk/eswin/clk-eic7700.c
Can you give us a clock-tree img or pdf?

                        - Troy