Re: [PATCH v3 5/5] clk: en7523: add support for Airoha AN7583 clock
From: Krzysztof Kozlowski
Date: Fri Nov 07 2025 - 02:44:17 EST
On Thu, Nov 06, 2025 at 08:59:32PM +0100, Christian Marangi wrote:
> +
> +static int an7583_clk_hw_init(struct platform_device *pdev,
> + const struct en_clk_soc_data *soc_data,
> + struct clk_hw_onecell_data *clk_data)
> +{
> + struct device *dev = &pdev->dev;
> + struct regmap *map, *clk_map;
> + void __iomem *base;
> + int err;
> +
> + map = syscon_regmap_lookup_by_phandle(dev->of_node, "airoha,chip-scu");
NAK, undocumented ABI.
We talked about this last time and you just ignored entire discussion.
Nothing in the changelog explains why this stayed, why our discussion
was resolved like this.
I already complained about very poor changelog and lack of lore links
and this just adds on top of it.
Best regards,
Krzysztof