Re: [PATCH v4 1/6] media: qcom: iris: Improve format alignment for encoder

[Wangao Wang]

On 2025/11/7 16:42, Dikshita Agarwal wrote:
> > @@ -231,8 +230,8 @@ static int iris_hfi_gen2_set_crop_offsets(struct iris_inst *inst, u32 plane)
> >   			top_offset = inst->compose.top;
> >   		}
> >   	} else {
> > -		bottom_offset = (inst->fmt_src->fmt.pix_mp.height - inst->crop.height);
> > -		right_offset = (inst->fmt_src->fmt.pix_mp.width - inst->crop.width);
> > +		bottom_offset = (inst->fmt_dst->fmt.pix_mp.height - inst->enc_raw_height);
> > +		right_offset = (inst->fmt_dst->fmt.pix_mp.width - inst->enc_raw_width);
>
> This should be move to 2nd patch where you clean the CROP offset property
> setting.

It will be modified in v5.


--
Best Regards,
Wangao