Re: [PATCH v4 2/6] media: qcom: iris: Improve crop_offset handling for encoder

[Wangao Wang]

On 2025/11/7 18:25, Dikshita Agarwal wrote:
> On 11/6/2025 9:00 AM, Wangao Wang wrote:
> > The setting of HFI_PROP_CROP_OFFSETS for the OUTPUT port is correct,
> > but on the CAPTURE port it is used to inform the firmware about the
> > ROI, so crop_offset needs to be handled accordingly.
> >
> > Signed-off-by: Wangao Wang <wangao.wang@xxxxxxxxxxxxxxxx>
>
> Does CROP use case work with just this patch and first one?
>
> Since you are enabling different features in your series, pls make sure
> features are working with individual patches.
>
> Thanks,
> Dikshita
> > ---
The crop for the input port works correctly with just these two patches.

--
Best Regards,
Wangao