Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause frame

[Mohsin Bashir]

> You should store this away in mac_link_up. Pause can be negotiated. It
> could be the link partner does not want pause, does not support pause.
> When phylink calls .mac_link_up this has all been determined and you
> then know how to setup the hardware. Here is too early.
>
> 	Andrew

Agreed. Even though fbnic currently does not support autoneg, moving 
this to .mac_link_up is the right approach. Thanks for the feedback.