Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause frame

[Andrew Lunn]

> @@ -36,8 +36,13 @@ int fbnic_phylink_set_pauseparam(struct net_device *netdev,
>  				 struct ethtool_pauseparam *pause)
>  {
>  	struct fbnic_net *fbn = netdev_priv(netdev);
> +	int err;
> +
> +	err = phylink_ethtool_set_pauseparam(fbn->phylink, pause);
> +	if (!err)
> +		fbn->tx_pause = pause->tx_pause ? true : false;

You should store this away in mac_link_up. Pause can be negotiated. It
could be the link partner does not want pause, does not support pause.
When phylink calls .mac_link_up this has all been determined and you
then know how to setup the hardware. Here is too early.

	Andrew