Re: [PATCH bpf-next v3] bpf: Clamp trace length in __bpf_get_stack to fix OOB write

[Lecomte, Arnaud]

On 12/11/2025 14:47, Brahmajit Das wrote:
> On 12.11.2025 13:35, David Laight wrote:
> > On Tue, 11 Nov 2025 13:42:54 +0530
> > Brahmajit Das <listout@xxxxxxxxxxx> wrote:
> ...snip...
> > Please can we have no unnecessary min_t().
> > You wouldn't write:
> > 	x = (u32)a < (u32)b ? (u32)a : (u32)b;
> >
> >      David
> >   
> > >   	copy_len = trace_nr * elem_size;
> > >   
> > >   	ips = trace->ip + skip;
> Hi David,
>
> Sorry, I didn't quite get that. Would prefer something like:
> 	trace_nr = (trace_nr <= num_elem) ? trace_nr : num_elem;

min_t is a min with casting which is unnecessary in this case as 
trace_nr and num_elem
are already u32.

> The pre-refactor code.