Re: [PATCH bpf-next v3] bpf: Clamp trace length in __bpf_get_stack to fix OOB write
From: Brahmajit Das
Date: Wed Nov 12 2025 - 09:48:08 EST
On 12.11.2025 13:35, David Laight wrote:
> On Tue, 11 Nov 2025 13:42:54 +0530
> Brahmajit Das <listout@xxxxxxxxxxx> wrote:
>
...snip...
>
> Please can we have no unnecessary min_t().
> You wouldn't write:
> x = (u32)a < (u32)b ? (u32)a : (u32)b;
>
> David
>
> > copy_len = trace_nr * elem_size;
> >
> > ips = trace->ip + skip;
>
Hi David,
Sorry, I didn't quite get that. Would prefer something like:
trace_nr = (trace_nr <= num_elem) ? trace_nr : num_elem;
The pre-refactor code.
--
Regards,
listout