Re: [PATCH 0/2] rbree: inline rb_first() and rb_last()

[Kuan-Wei Chiu]

Hi Eric,

On Fri, Nov 14, 2025 at 02:06:44PM +0000, Eric Dumazet wrote:
> Inline these two small helpers, heavily used in TCP and FQ packet scheduler,
> and in many other places.
> 
> This reduces kernel text size, and brings an 1.5 % improvement on network
> TCP stress test.

Thanks for the patch!

Just out of curiosity, do you think rb_first() and rb_last() would be
worth marking with __always_inline?

Regardless, for the series:

Reviewed-by: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>

Regards,
Kuan-Wei
> 
> Eric Dumazet (2):
>   rbtree: inline rb_first()
>   rbtree: inline rb_last()
> 
>  include/linux/rbtree.h | 32 ++++++++++++++++++++++++++++++--
>  lib/rbtree.c           | 29 -----------------------------
>  2 files changed, 30 insertions(+), 31 deletions(-)
> 
> -- 
> 2.52.0.rc1.455.g30608eb744-goog
> 
>