Re: [PATCH 0/2] rbree: inline rb_first() and rb_last()
From: Eric Dumazet
Date: Sun Nov 16 2025 - 13:41:55 EST
On Sun, Nov 16, 2025 at 10:00 AM Kuan-Wei Chiu <visitorckw@xxxxxxxxx> wrote:
>
> Hi Eric,
>
> On Fri, Nov 14, 2025 at 02:06:44PM +0000, Eric Dumazet wrote:
> > Inline these two small helpers, heavily used in TCP and FQ packet scheduler,
> > and in many other places.
> >
> > This reduces kernel text size, and brings an 1.5 % improvement on network
> > TCP stress test.
>
> Thanks for the patch!
>
> Just out of curiosity, do you think rb_first() and rb_last() would be
> worth marking with __always_inline?
I have not seen any difference, what compilers are you using that
would not inline this ?