Re: [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin_ranges()

[Mika Westerberg]

On Mon, Nov 17, 2025 at 08:57:00AM +0100, Andy Shevchenko wrote:
> Export intel_gpio_add_pin_ranges() for reuse in other drivers.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/intel/pinctrl-intel.c | 3 ++-
>  drivers/pinctrl/intel/pinctrl-intel.h | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
> index a8b80a24e81f..2424b1bcc322 100644
> --- a/drivers/pinctrl/intel/pinctrl-intel.c
> +++ b/drivers/pinctrl/intel/pinctrl-intel.c
> @@ -1345,7 +1345,7 @@ static int intel_gpio_irq_init_hw(struct gpio_chip *gc)
>  	return 0;
>  }
>  
> -static int intel_gpio_add_pin_ranges(struct gpio_chip *gc)

As this is now exported, can you add kernel-doc too?

> +int intel_gpio_add_pin_ranges(struct gpio_chip *gc)
>  {
>  	struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
>  	struct device *dev = pctrl->dev;
> @@ -1361,6 +1361,7 @@ static int intel_gpio_add_pin_ranges(struct gpio_chip *gc)
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_NS_GPL(intel_gpio_add_pin_ranges, "PINCTRL_INTEL");
>  
>  static unsigned int intel_gpio_ngpio(const struct intel_pinctrl *pctrl)
>  {
> diff --git a/drivers/pinctrl/intel/pinctrl-intel.h b/drivers/pinctrl/intel/pinctrl-intel.h
> index 654af5977603..545bed9fb96c 100644
> --- a/drivers/pinctrl/intel/pinctrl-intel.h
> +++ b/drivers/pinctrl/intel/pinctrl-intel.h
> @@ -273,6 +273,8 @@ int intel_pinctrl_probe_by_uid(struct platform_device *pdev);
>  
>  extern const struct dev_pm_ops intel_pinctrl_pm_ops;
>  
> +int intel_gpio_add_pin_ranges(struct gpio_chip *gc);
> +

Can you move this down a bit, above intel_get_groups_count()?

>  const struct intel_community *intel_get_community(const struct intel_pinctrl *pctrl,
>  						  unsigned int pin);
>  
> -- 
> 2.50.1