Re: [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin_ranges()

From: Andy Shevchenko
Date: Tue Nov 18 2025 - 07:13:34 EST


On Tue, Nov 18, 2025 at 1:47 PM Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Mon, Nov 17, 2025 at 08:57:00AM +0100, Andy Shevchenko wrote:
> > Export intel_gpio_add_pin_ranges() for reuse in other drivers.

...

> > -static int intel_gpio_add_pin_ranges(struct gpio_chip *gc)
>
> As this is now exported, can you add kernel-doc too?

OK.

...

> > +int intel_gpio_add_pin_ranges(struct gpio_chip *gc);
>
> Can you move this down a bit, above intel_get_groups_count()?

Sure.

--
With Best Regards,
Andy Shevchenko