Re: [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link

[Russell King (Oracle)]

On Tue, Nov 18, 2025 at 03:00:00PM +0100, Andrew Lunn wrote:
> > > > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link
> > > > configuration")
> > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > > > Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> > > 
> > > NAK. I give up.
> > > 
> > 
> > Sorry, could you please tell me what the reason is?
> 
> I think Russell is referring to the commit message, and how you only
> quoted a little section of his explanation. There is no limit to
> commit messages, they don't need to be short. It is actually better if
> they are long. So you could use his whole explanation. And then you
> don't need the link.

Worse than that. I gave my reviewed-by, which seems to have been a waste
of time.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!