RE: [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link

From: Wei Fang

Date: Tue Nov 18 2025 - 20:22:21 EST


> On Tue, Nov 18, 2025 at 03:00:00PM +0100, Andrew Lunn wrote:
> > > > > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link
> > > > > configuration")
> > > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > > > > Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> > > >
> > > > NAK. I give up.
> > > >
> > >
> > > Sorry, could you please tell me what the reason is?
> >
> > I think Russell is referring to the commit message, and how you only
> > quoted a little section of his explanation. There is no limit to
> > commit messages, they don't need to be short. It is actually better if
> > they are long. So you could use his whole explanation. And then you
> > don't need the link.
>
> Worse than that. I gave my reviewed-by, which seems to have been a waste
> of time.
>

I'm sorry, I was in a rush to send out the v3 patch, and I hadn't received
your Reviewed-by tag at that time, so the tag was not added. When I saw
that you gave the Review-by in v2, I realized that I could no longer add it
to v3, so I replied that I had sent v3, hoping that you could resend your
Reviewed-by tag.

If you don't mind, I will refine the commit message as Andrew suggested
and add your Revived-by tag from v2 to v4. I apologize again.