RE: [PATCH v3 08/13] serial: sh-sci: Add sci_is_rsci_type()

[Biju Das]

Hi Geert,

Thanks for the feedback,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 21 November 2025 15:17
> Subject: Re: [PATCH v3 08/13] serial: sh-sci: Add sci_is_rsci_type()
> 
> Hi Biju,
> 
> On Fri, 14 Nov 2025 at 11:52, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Add sci_is_rsci_type() for RSCI port type. This will simplify the code
> > when the support added for RSCI_PORT_{SCI,SCIF} private PORT type.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -1182,6 +1182,11 @@ static int sci_handle_errors(struct uart_port *port)
> >         return copied;
> >  }
> >
> > +static bool sci_is_rsci_type(u8 type) {
> > +       return (type == SCI_PORT_RSCI || type == RSCI_PORT_SCI || type
> > +== RSCI_PORT_SCIF);
> 
> Would be much more consistent if all port types would use the
> RSCI_PORT_* prefix...

Agreed, Will update.

Cheers,
Biju