Re: [PATCH] i2c: i2c-elektor: Allow building on SMP kernels

[John Paul Adrian Glaubitz]

Hi Magnus,

On Sat, 2025-11-22 at 13:26 +0100, Magnus Lindholm wrote:
> It the past the i2c-elektor driver has been broken on SMP, as it seems

Typo: s/It/In/ and I think there should be a full stop after "SMP".

> there has since been some fixes/cleanup work to get rid of cli/sti and

s/has/have/

> rely on spinlocks instead (as pointed out by Wolfram Sang). Tested this

The sentence just ends after "instead". I think you meant to say "instead,
let's allow building the driver on SMP kernels again." or something like
that.

> driver on SMP kernel on Alpha/UP2000+ for a few days without any problems.
> 
> Signed-off-by: Magnus Lindholm <linmag7@xxxxxxxxx>
> ---
>  drivers/i2c/busses/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index fd81e49638aa..9b1473d720a0 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1474,7 +1474,7 @@ config I2C_ACORN
>  
>  config I2C_ELEKTOR
>  	tristate "Elektor ISA card"
> -	depends on ISA && HAS_IOPORT_MAP && BROKEN_ON_SMP
> +	depends on ISA && HAS_IOPORT_MAP
>  	select I2C_ALGOPCF
>  	help
>  	  This supports the PCF8584 ISA bus I2C adapter.  Say Y if you own

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913