Re: [PATCH 1/4] dt-bindings: clock: google,gs101-clock: Add DPU clock management unit

[Krzysztof Kozlowski]

On Thu, Nov 20, 2025 at 09:06:11PM +0000, Peter Griffin wrote:
> Add dt schema documentation and clock IDs for the Display Process Unit
> (DPU) clock management unit (CMU). This CMU feeds IPs such as image scaler,
> enhancer and compressor.
> 
> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> ---
>  .../bindings/clock/google,gs101-clock.yaml         | 19 ++++++++++++
>  include/dt-bindings/clock/google,gs101.h           | 36 ++++++++++++++++++++++
>  2 files changed, 55 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> index 09e679c1a9def03d53b8b493929911ea902a1763..1257be9c54a42ea2387e1112e53b5ee1f03e09f5 100644
> --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> @@ -34,6 +34,7 @@ properties:
>        - google,gs101-cmu-hsi2
>        - google,gs101-cmu-peric0
>        - google,gs101-cmu-peric1
> +      - google,gs101-cmu-dpu

Standard comment - oddly placed. d < p. Or you just always keep adding
at the end?

>  
>    clocks:
>      minItems: 1
> @@ -171,6 +172,24 @@ allOf:
>              - const: bus
>              - const: ip
>  
> +  - if:

This as well follows alphanumeric placement.

Best regards,
Krzysztof