Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values

[Markus Elfring]

>>> +++ b/mm/zswap.c
>>> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>>>  
>>>  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
>>>  	if (IS_ERR(acomp)) {
>> …
>>> +		pr_err("could not alloc crypto acomp %s : %pe\n",
>>> +				pool->tfm_name, acomp);
>>>  		ret = PTR_ERR(acomp);
>> …
>>
>> Would you like to reduce the indentation for the passed parameters?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110
> 
> That is the exact opposite of what this suggestion is intended to say.

I wonder about the interpretation of the provided information in such a direction.


> Sahil, you should ignore any suggestion made to you by Markus.

Do you try to distract from reminders according to a known information source here?

Regards,
Markus