Re: [PATCH v4 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

[Krzysztof Kozlowski]

On 18/11/2025 20:07, Conor Dooley wrote:
> On Tue, Nov 18, 2025 at 09:11:42AM +0800, Khairul Anuar Romli wrote:
>> Agilex5 introduces changes in how reserved memory is mapped and accessed
>> compared to previous SoC generations. Agilex5 compatible allows stratix10-
>> FPGA manager driver to handle these changes.
>>
>> Fallback is added for driver probe and init that rely on matching of table
>> and DT node.
>>
>> Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxx>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
>> ---
>> Changes in v4:
>> 	- Remove redundant "items - enum" as suggested in v3.
>> 	- Simplify compatible property to use contains instead of oneOf.
>> 	- Validate fallback and non-fallback DT. Also validate binding with
>>           dt_binding_check.
> 
> What are you doing?? You've been told several times exactly what to do
> and yet you keep conjuring up completely random different things.
> Using contains instead of the oneOf construct that was being done before
> is *not* a simplification, it is functionally different.
> 
> NAK. Go do what you were told to do.

There is no single file with that syntax, so I really do not understand
why completely different syntax is reasonable for the author :/

Best regards,
Krzysztof