Re: [PATCH 6.12 000/565] 6.12.58-rc1 review

[Pavel Machek]

Hi!

> Zizhi Wo <wozizhi@xxxxxxxxxxxxxxx>
>     tty/vt: Add missing return value for VT_RESIZE in vt_ioctl()

This one was backported wrongly to 6.12:

+++ b/drivers/tty/vt/vt_ioctl.c
@@ -923,7 +923,9 @@ int vt_ioctl(struct tty_struct *tty,
 
                        if (vc) {
                                /* FIXME: review v tty lock */
-                               __vc_resize(vc_cons[i].d, cc, ll, true);
+                               ret = __vc_resize(vc_cons[i].d, cc, ll, true);
+                               if (ret)
+                                       return ret;
                        }
                }
                console_unlock();

It needs to do console_unlock() before returning.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature