Re: [PATCH 6.12 000/565] 6.12.58-rc1 review

[Jari Ruusu]

Pavel Machek <pavel@xxxxxxx> wrote:
> > Zizhi Wo <wozizhi@xxxxxxxxxxxxxxx>
> >     tty/vt: Add missing return value for VT_RESIZE in vt_ioctl()
> 
> This one was backported wrongly to 6.12:
> 
> +++ b/drivers/tty/vt/vt_ioctl.c
> @@ -923,7 +923,9 @@ int vt_ioctl(struct tty_struct *tty,
>  
>                         if (vc) {
>                                 /* FIXME: review v tty lock */
> -                               __vc_resize(vc_cons[i].d, cc, ll, true);
> +                               ret = __vc_resize(vc_cons[i].d, cc, ll, true);
> +                               if (ret)
> +                                       return ret;
>                         }
>                 }
>                 console_unlock();
> 
> It needs to do console_unlock() before returning.

I have already sent 2 emails about this, but Greg's to-do
list seems to be very long, or something like that.

https://lore.kernel.org/lkml/zuLBWV-yhJXc0iM4l5T-O63M-kKmI2FlUSVgZl6B3WubvFEHRbBYQyhKsRcK4YyKk_iePF4STJihe7hx5H3KCU2KblG32oXwsxn9tzpTm5w=@protonmail.com/

https://lore.kernel.org/lkml/8mT8aJsAQPfUnmI5mmsgbUweQAptUFDu5XqhrxPPI1DgJr7GPpbwrpQQW22Nj7fsBc5M5YKG8g0EceNQ_b3d-RPhk6RSQgGCqvaVzzWSIQw=@protonmail.com/

That second email has a small test program to demo the
problem and a patch to fix it for 6.12.58+ and 6.17.8+

--
Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189