Re: [PATCH 6.12 000/185] 6.12.59-rc1 review

[Pavel Machek]

On Fri 2025-11-21 14:10:27, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.12.59 release.
> There are 185 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.


> Takashi Iwai <tiwai@xxxxxxx>
>     ALSA: usb-audio: Fix potential overflow of PCM transfer buffer

This one is wrong for at least 6.12 and older.

+       if (ep->packsize[1] > ep->maxpacksize) {
+               usb_audio_dbg(chip, "Too small maxpacksize %u for rate %u / pps %u\n",
+                             ep->maxpacksize, ep->cur_rate, ep->pps);
+               return -EINVAL;
+       }
 
Needs to be err = -EINVAL; goto unlock;.

(Or cherry pick guard() handling from newer kernels).

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature