Re: [PATCH] ipv4: Fix log message for martian source

[Clara Engler]

On Thu, Nov 27, 2025 at 06:17:43PM -0800, Jakub Kicinski wrote:
> imagine there was another comma in this print:
> 
> 	martian source, %pI4 from %pI4, on dev %s
> 
> we should leave it as is, I think.

Yes, this comma indeed makes it more helpful.

Personally, my preference would lie in a format such as the following:

    martian source (src={SRC}, dst={DST}, dev={DEV}

with a respective similar change to the martian destination.

> People may be grepping logs for this exact format..

I agree with you partially.  For such a trivial change, it is probably
not worth to pursue this any further, but I don't think "log stability"
is something to aim for/guarantee.

Thank You
Clara