Re: [PATCH] ipv4: Fix log message for martian source

[Jakub Kicinski]

On Wed, 26 Nov 2025 22:59:58 +0100 Clara Engler wrote:
> @@ -1796,7 +1796,7 @@ static void ip_handle_martian_source(struct net_device *dev,
>  		 *	the only hint is MAC header.
>  		 */
>  		pr_warn("martian source %pI4 from %pI4, on dev %s\n",
> -			&daddr, &saddr, dev->name);
> +			&saddr, &daddr, dev->name);

imagine there was another comma in this print:

	martian source, %pI4 from %pI4, on dev %s

we should leave it as is, I think.
People may be grepping logs for this exact format..
-- 
pw-bot: reject