RE: [EXT] Re: [PATCH v7 1/2] dt-bindings: rtc: Add pcf85053 support

[Lakshay Piplani]

> -----Original Message-----
> From: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Sent: Thursday, November 27, 2025 6:45 PM
> To: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> Cc: linux-rtc@xxxxxxxxxxxxxxx; Priyanka Jain <priyanka.jain@xxxxxxx>; Conor
> Dooley <conor.dooley@xxxxxxxxxxxxx>; Vikash Bansal
> <vikash.bansal@xxxxxxx>; krzk+dt@xxxxxxxxxx; Shashank Rebbapragada
> <shashank.rebbapragada@xxxxxxx>; Pankit Garg <pankit.garg@xxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; conor+dt@xxxxxxxxxx;
> alexandre.belloni@xxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v7 1/2] dt-bindings: rtc: Add pcf85053 support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Thu, 27 Nov 2025 17:34:55 +0530, Lakshay Piplani wrote:
> > Add device tree bindings for NXP PCF85053 RTC chip.
> >
> > Signed-off-by: Pankit Garg <pankit.garg@xxxxxxx>
> > Signed-off-by: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > ---
> > V6 -> V7: - no changes
> >         - Added Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > V5 -> V6: - Dropped driver-specific commentary from property descriptions.
> >         - Simplified and clarified descriptions for better readability.
> > V4 -> V5: - Updated schema validation logic to enforce correct combinations
> of
> >             'nxp,interface' and 'nxp,write-access' using oneOf clauses.
> >           - Refined property descriptions for clarity and hardware alignment.
> > V3 -> V4: Add dedicated nxp,pcf85053.yaml.
> >           Remove entry from trivial-rtc.yaml.
> > V2 -> V3: Moved MAINTAINERS file changes to the driver patch
> > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
> >
> >  .../devicetree/bindings/rtc/nxp,pcf85053.yaml | 114
> > ++++++++++++++++++
> >  1 file changed, 114 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb:
> /example-0/soc/thermal-sensor@c263000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb:
> /example-0/soc/thermal-sensor@c263000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb:
> /example-0/soc/thermal-sensor@c265000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-zones.example.dtb:
> /example-0/soc/thermal-sensor@c265000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb:
> /example-0/soc/thermal-sensor@c263000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb:
> /example-0/soc/thermal-sensor@c263000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb:
> /example-0/soc/thermal-sensor@c265000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb:
> /example-0/soc/thermal-sensor@c265000: failed to match any schema with
> compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fproject%2Fdevicetree-
> bindings%2Fpatch%2F20251127120456.1849177-1-
> lakshay.piplani%40nxp.com&data=05%7C02%7Clakshay.piplani%40nxp.com%
> 7C6d7bbae4a787415e631708de2db700c9%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C638998461167266618%7CUnknown%7CTWFpbGZsb3d8
> eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIj
> oiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Pps7Ic5ozHTrXGDeb
> lYEOBSy9MKZo6iJi5zhHjGB94k%3D&reserved=0
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.

Hi Rob,

Thanks for the review.

I have updated dtschema to the latest version and checked the binding.
The reported errors are not related to the patch I submitted.

Additionally, this patch has been tested on the latest mainline kernel.

Thanks,
Lakshay