Re: [PATCH] ublk: prevent invalid access with DEBUG
From: Jens Axboe
Date: Wed Nov 26 2025 - 15:32:59 EST
On Wed, 26 Nov 2025 12:48:35 +0000, Kevin Brodsky wrote:
> ublk_ch_uring_cmd_local() may jump to the out label before
> initialising the io pointer. This will cause trouble if DEBUG is
> defined, because the pr_devel() call dereferences io. Clang reports:
>
> drivers/block/ublk_drv.c:2403:6: error: variable 'io' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> 2403 | if (tag >= ub->dev_info.queue_depth)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/block/ublk_drv.c:2492:32: note: uninitialized use occurs here
> 2492 | __func__, cmd_op, tag, ret, io->flags);
> |
>
> [...]
Applied, thanks!
[1/1] ublk: prevent invalid access with DEBUG
(no commit info)
Best regards,
--
Jens Axboe