Re: [PATCH v1 09/31] serial: 8250: split 8250_mxpcie from 8250_pci

[Crescent Hsieh]

On Sun, Nov 30, 2025 at 09:22:20PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 30, 2025 at 12:44 PM Crescent Hsieh
> <crescentcy.hsieh@xxxxxxxx> wrote:
> > +#include <linux/module.h>
> > +#include <linux/pci.h>
> 
> This needs more headers to be included
> 
> bitfield.h
> bits.h
> dev_printk.h
> device/devres.h
> ioport.h
> types.h

May I ask a clarification: my understanding was to include headers only
when the corresponding symbols are directly used.

Is the intention here to avoid relying on implicit includes and to make
the driver’s dependencies explicit?

---
Sincerely,
Crescent Hsieh