Re: [PATCH v1 09/31] serial: 8250: split 8250_mxpcie from 8250_pci

[Andy Shevchenko]

On Wed, Dec 3, 2025 at 4:54 AM Crescent Hsieh <crescentcy.hsieh@xxxxxxxx> wrote:
>
> On Sun, Nov 30, 2025 at 09:22:20PM +0200, Andy Shevchenko wrote:
> > On Sun, Nov 30, 2025 at 12:44 PM Crescent Hsieh
> > <crescentcy.hsieh@xxxxxxxx> wrote:
> > > +#include <linux/module.h>
> > > +#include <linux/pci.h>
> >
> > This needs more headers to be included
> >
> > bitfield.h
> > bits.h
> > dev_printk.h
> > device/devres.h
> > ioport.h
> > types.h
>
> May I ask a clarification: my understanding was to include headers only
> when the corresponding symbols are directly used.

Yes, and that's what I have checked (I spent some time reading the
whole patch, but I might even miss something, so this list might be
not comprehensive).

> Is the intention here to avoid relying on implicit includes and to make
> the driver’s dependencies explicit?

Yes.


-- 
With Best Regards,
Andy Shevchenko