Re: [RFC PATCH 1/3] staging: iio: ad9832: remove platform_data support

From: Andy Shevchenko

Date: Sat Dec 06 2025 - 11:24:24 EST


On Fri, Dec 05, 2025 at 05:27:41PM -0300, Tomas Borquez wrote:
> Remove legacy platform_data support as there are no in tree users and
> this approach belongs to a long gone era. The policy decision on what
> to output is a userspace problem, not something that should be provided
> from firmware.
>
> The driver now initializes the device to a safe state (SLEEP|RESET|CLR)
> outputting nothing. Userspace can configure the desired frequencies and
> phases via the existing sysfs attributes once the device is ready to be

Tailing space on the above line (and the only line with this issue).

> used.
>
> Original discussion started here [1].

The change LGTM, Jonathan, can you amend the above and apply it?
(Yes, I have read the discussion about removal the driver, but meanwhile
the change is good on itself even if we are going to remove the driver.
It just makes an additional harmless step in my opinion.)

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko