Re: [PATCH 3/3] mshv: Add debugfs to view hypervisor statistics

[Nuno Das Neves]

On 12/3/2025 11:21 AM, Stanislav Kinsburskii wrote:
> On Wed, Dec 03, 2025 at 09:53:25AM -0800, Nuno Das Neves wrote:
>> Introduce a debugfs interface to expose root and child partition stats
>> when running with mshv_root.
>>
> 
> <snip>
>> +static void mshv_debugfs_parent_partition_remove(void)
> 
> nit: it makes sense to add __exit to this method.
> 
> <snip>
> 
>> +
>> +void mshv_debugfs_exit(void)
> 
> Ditto.

It looks like __exit is purposely omitted here, because
mshv_debugfs_exit() is called in the error cleanup path of
mshv_parent_partition_init().

Thanks
Nuno

> 
> Reviewed-by: Stanislav Kinsburskii <skinsburskii@xxxxxxxxxxxxxxxxxxx>
> 
> Thanks,
> Stanislav