Re: [PATCH] pinctrl: add CONFIG_OF dependencies for microchip drivers
From: Andy Shevchenko
Date: Thu Dec 04 2025 - 13:56:35 EST
On Thu, Dec 04, 2025 at 02:44:36PM +0100, Arnd Bergmann wrote:
> On Thu, Dec 4, 2025, at 13:11, Andy Shevchenko wrote:
> > On Thu, Dec 04, 2025 at 10:50:14AM +0100, Arnd Bergmann wrote:
> >>
> >> The two newly added drivers fail to link on builds without
> >> CONFIG_OF:
> >>
> >> x86_64-linux-ld: drivers/pinctrl/pinctrl-pic64gx-gpio2.o: in function `pinconf_generic_dt_node_to_map_all':
> >> pinctrl-pic64gx-gpio2.c:(.text+0xc9): undefined reference to `pinconf_generic_dt_node_to_map'
> >> x86_64-linux-ld: drivers/pinctrl/pinctrl-mpfs-iomux0.o: in function `pinconf_generic_dt_node_to_map_all':
> >> pinctrl-mpfs-iomux0.c:(.text+0xc9): undefined reference to `pinconf_generic_dt_node_to_map'
> >>
> >> Add a Kconfig dependencies.
> >
> > This will reduce the compile test base. In other drivers we usually put
> > ifdeffery in the code.
>
> I usually prefer the Kconfig dependency: It's still covered by
> both allmodconfig and half the randconfig tests on the few
> architectures that don't already require CONFIG_OF on all builds.
OK!
--
With Best Regards,
Andy Shevchenko