Re: [PATCH 3/8] dt-bindings: pinctrl: renesas,r9a09g077-pinctrl: Document GPIO IRQ
From: Krzysztof Kozlowski
Date: Thu Dec 04 2025 - 11:00:08 EST
On 04/12/2025 10:30, Cosmin-Gabriel Tanislav wrote:
>>> @@ -119,6 +130,8 @@ required:
>>> - gpio-controller
>>> - '#gpio-cells'
>>> - gpio-ranges
>>> + - interrupt-controller
>>> + - '#interrupt-cells'
>>
>> This is technically an ABI break thus commit msg must explain WHY
>> breaking ABI is necessary and what is the impact on users.
>>
>> If your driver keeps things backwards compatible, then briefly mention
>> it in the commit msg that you require it only for complete hardware
>> picture. Or for whatever other reason.
>>
>
>
> It's not exactly required for the pinctrl to be defined as an interrupt
> controller, only if you use the interrupt functionality of the pins...
> I can remove them from required, that should keep compatibility.
>
> Would that be fine?
Yes.
Best regards,
Krzysztof