RE: [PATCH 3/8] dt-bindings: pinctrl: renesas,r9a09g077-pinctrl: Document GPIO IRQ

[Cosmin-Gabriel Tanislav]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Wednesday, December 3, 2025 10:04 AM
> To: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@xxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; Rob
> Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; magnus.damm <magnus.damm@xxxxxxxxx>; Prabhakar Mahadev Lad <prabhakar.mahadev-
> lad.rj@xxxxxxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/8] dt-bindings: pinctrl: renesas,r9a09g077-pinctrl: Document GPIO IRQ
> 
> On Fri, Nov 21, 2025 at 01:26:21PM +0200, Cosmin Tanislav wrote:
> > The Renesas RZ/T2H (R9A09G077) and Renesas RZ/N2H (R9A09G087) SoCs have
> > IRQ-capable pins handled by the ICU, which forwards them to the GIC.
> >
> > The ICU supports 16 IRQ lines, the pins map to these lines arbitrarily,
> > and the mapping is not configurable.
> >
> > Document the required properties to handle GPIO IRQ.
> >
> > Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@xxxxxxxxxxx>
> > ---
> >  .../pinctrl/renesas,r9a09g077-pinctrl.yaml        | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,r9a09g077-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/renesas,r9a09g077-pinctrl.yaml
> > index 36d665971484..1e171b443da1 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,r9a09g077-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,r9a09g077-pinctrl.yaml
> > @@ -49,6 +49,17 @@ properties:
> >    gpio-ranges:
> >      maxItems: 1
> >
> > +  interrupt-controller: true
> > +
> > +  '#interrupt-cells':
> > +    const: 2
> > +    description:
> > +      The first cell contains the global GPIO port index, constructed using the
> > +      RZT2H_GPIO() helper macro from <dt-bindings/pinctrl/renesas,r9a09g077-pinctrl.h>
> > +      and the second cell is used to specify the flag.
> > +      E.g. "interrupts = <RZT2H_GPIO(8, 6) IRQ_TYPE_EDGE_FALLING>;" if P08_6 is
> > +      being used as an interrupt.
> > +
> >    clocks:
> >      maxItems: 1
> >
> > @@ -119,6 +130,8 @@ required:
> >    - gpio-controller
> >    - '#gpio-cells'
> >    - gpio-ranges
> > +  - interrupt-controller
> > +  - '#interrupt-cells'
> 
> This is technically an ABI break thus commit msg must explain WHY
> breaking ABI is necessary and what is the impact on users.
> 
> If your driver keeps things backwards compatible, then briefly mention
> it in the commit msg that you require it only for complete hardware
> picture. Or for whatever other reason.
>


It's not exactly required for the pinctrl to be defined as an interrupt
controller, only if you use the interrupt functionality of the pins...
I can remove them from required, that should keep compatibility.

Would that be fine?

> Best regards,
> Krzysztof