Re: [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick in virtio_crypto_skcipher_crypt_req

From: Jason Wang
Date: Mon Dec 08 2025 - 23:32:50 EST


On Tue, Dec 9, 2025 at 12:31 PM Jason Wang <jasowang@xxxxxxxxxx> wrote:
>
> On Tue, Dec 9, 2025 at 10:00 AM Bibo Mao <maobibo@xxxxxxxxxxx> wrote:
> >
> > With function virtio_crypto_skcipher_crypt_req(), there is already
> > virtqueue_kick() call with spinlock held in funtion
>
> A typo should be "function".
>
> > __virtio_crypto_skcipher_do_req(). Remove duplicated virtqueue_kick()
> > function call here.
> >
> > Signed-off-by: Bibo Mao <maobibo@xxxxxxxxxxx>
>
> Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

Btw.

I think this probably deserved a stable tag as well as the
virtqueue_kick is not synchronized here?

>
> Thanks

Thanks