Re: [PATCH v3 02/10] crypto: virtio: Remove duplicated virtqueue_kick in virtio_crypto_skcipher_crypt_req

From: Bibo Mao
Date: Tue Dec 09 2025 - 20:23:21 EST




On 2025/12/9 下午12:32, Jason Wang wrote:
On Tue, Dec 9, 2025 at 12:31 PM Jason Wang <jasowang@xxxxxxxxxx> wrote:

On Tue, Dec 9, 2025 at 10:00 AM Bibo Mao <maobibo@xxxxxxxxxxx> wrote:

With function virtio_crypto_skcipher_crypt_req(), there is already
virtqueue_kick() call with spinlock held in funtion

A typo should be "function".
Good catch, will correct this.

__virtio_crypto_skcipher_do_req(). Remove duplicated virtqueue_kick()
function call here.

Signed-off-by: Bibo Mao <maobibo@xxxxxxxxxxx>

Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

Btw.

I think this probably deserved a stable tag as well as the
virtqueue_kick is not synchronized here?
sure, will do in next version.

Regards
Bibo Mao


Thanks

Thanks