Re: [PATCH 2/2] nvme/host: fixup some typos
From: Damien Le Moal
Date: Tue Dec 16 2025 - 20:42:47 EST
On 12/16/25 12:29, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>
>
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>
Looks good, but write something as the commit message.
One nit below.
Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> @@ -271,7 +271,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl,
> {
> if (ns && nsid != ns->head->ns_id) {
> dev_err(ctrl->device,
> - "%s: nsid (%u) in cmd does not match nsid (%u)"
> + "%s: nsid (%u) in cmd does not match nsid (%u) "
> "of namespace\n",
I know that Christoph does not like long lines, but it may be better to unwrap
this message to make it easier to grep the code.
--
Damien Le Moal
Western Digital Research