Re: [PATCH] RDMA/ucma: fix rdma_ucm_query_ib_service_resp struct padding

From: Jason Gunthorpe
Date: Tue Dec 16 2025 - 20:46:05 EST


On Mon, Dec 08, 2025 at 02:33:05PM +0100, Arnd Bergmann wrote:
> diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
> index 5ded174687ee..8e1d584f6633 100644
> --- a/include/uapi/rdma/rdma_user_cm.h
> +++ b/include/uapi/rdma/rdma_user_cm.h
> @@ -192,6 +192,7 @@ struct rdma_ucm_query_path_resp {
>
> struct rdma_ucm_query_ib_service_resp {
> __u32 num_service_recs;
> + __u32 :32;
> struct ib_user_service_rec recs[];
> };

RDMA doesn't use bitfields here, I changed these to be reserved like
the others.

> @@ -362,6 +363,7 @@ struct rdma_ucm_ib_service {
>
> struct rdma_ucm_resolve_ib_service {
> __u32 id;
> + __u32 :32;
> struct rdma_ucm_ib_service ibs;
> };

And I added the missing

struct rdma_ucm_ib_service {
- __u64 service_id;
+ __aligned_u64 service_id;

Again, like the others.

Applied to for-rc thanks

Jason